@corngood, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @dezgeg and @globin to be potential reviewers.

• This is a huge patch. Could it be fetched using fetchurl instead of keeping it in tree?

• How is this patch going to be maintained? We frequently need to do urgent OpenSSL upgrades so we don't want to have figure out how to update this patch first.

• Maybe this patch can be applied to the OpenSSL used by Steam only? It does not seem relevant anywhere else.

This is a huge patch. Could it be fetched using fetchurl instead of keeping it in tree?

I pulled it out of the ubuntu src tarball. I could probably find a way to automate that, but I'm not sure how reliable it would be (are there suitable permalinks?). It's 100kb and 4k lines, and 25kb gzipped. It's basically just a list of all public symbols grouped by the version where they were introduced.

I'll do a bit of investigating to see if it's machine-generated and who/what maintains it.

How is this patch going to be maintained? We frequently need to do urgent OpenSSL upgrades so we don't want to have figure out how to update this patch first.

It shouldn't require any maintenance (for this purpose) unless you are trying to roll-back to pre-1.0.2, or if the steam runtime moves to a newer version, and even then it could only break things in steam-land that need the new symbols.

Maybe this patch can be applied to the OpenSSL used by Steam only? It does not seem relevant anywhere else.

That's what's happening with this patch. It should have zero impact outside of the steam chroot environment.

This is WIP because @FRidh reported a crash in a commercial game (Wargame: European Escalation) which I don't have access to. So I'm just waiting for someone to confirm the fix.

The PR causing trouble: #20269
Issue: #20726

@corngood this does not fix the issue.

So no difference?

If you do:

nix-build -A steamPackages.steam-runtime
nm -D result/lib/x86_64-linux-gnu/libcrypto.so.1.0.0 | grep OPENSSL_1

Do you see the version symbols? I see:

0000000000000000 A OPENSSL_1.0.0
0000000000000000 A OPENSSL_1.0.1

Do you know if the game is 32-bit?

My machine just broke down so it might take a bit longer before I can test again and answer your questions.

Removing WIP. I haven't had any problems with it, and I don't see what harm it could cause.

So no difference?

Indeed, there was no difference.

nix-build -A steamPackages.steam-runtime
nm -D result/lib/x86_64-linux-gnu/libcrypto.so.1.0.0 | grep OPENSSL_1

results in the same symbols you showed.

Do you know if the game is 32-bit?

Wargame: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 2.6.24, BuildID[sha1]=595f2525c683f3cd4d7f2a5b3336a4ba62121f3c, stripped

Note that other 32-bit games work fine.

Maybe it's the same problem we were discussing in #20726 (comment) ?

Have you tried removing "no-engine" from the steam openssl?

I replied at #20726 (comment)

I'm going to close this since it doesn't appear to be the solution to anything. We can discuss other options on the issue.