Add call protocol to script body and separate non-protocol metas. #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clear StaticScope's dynscope constructor when variable names are altered. * Clean up jitted top-level script boot logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds call protocol to script bodies. This fixes recent compiler regressions caused by ripping the non-protocol logic out of CompiledIRMethod (#4382).
It appears the only scopes which do not get call protocol now are eval scopes and singleton class scopes (IRMetaClassBody). The former is never jitted and never put into CompiledIRMethod or any other context where its protocol is not already handled. The latter had its own CompiledIRMetaClassBody whose sole difference was to do pre/post call protocol, so it is renamed to reflect that.