User editing interface updates + logo uploading #246
Conversation
| @@ -20,6 +20,7 @@ CREATE TABLE "user" ( | |||
| contact_email CHARACTER VARYING NOT NULL, | |||
| data_usage_desc TEXT, | |||
| org_name CHARACTER VARYING, | |||
| logo_filename CHARACTER VARYING, | |||
There was a problem hiding this comment.
Why is this needed? Can the filename not be parsed from the org_logo_url?
There was a problem hiding this comment.
Ah, I see. You've depricated the old logo URL, but still kept it. I think this complicated the code unnecessarily and we should get rid of the old org_logo_url and write a script that moves the legacy supporters into the new format. Then drop the old column.
There was a problem hiding this comment.
This filename is generated randomly so we need to know the name.
Another thing is that people who register still have a way to provide a URL for a logo. Do you use it often or just ask them to send one?
There was a problem hiding this comment.
More often than not, I have to ask them for one. Very few provide a usable logo file -- I would suggest that we can leave that out for people to add themselves and I'll ask for it when we starting billing them.
There was a problem hiding this comment.
Then we can remove it afterwards. I think it would be faster to just move all the logos by hand than to write a script. There aren't as many, I'll do it myself.
| @@ -0,0 +1,240 @@ | |||
| {% extends 'admin/master.html' %} | |||
There was a problem hiding this comment.
Was there no old template that did most of this before? Looks like a new file, but we had this feature before and I don't see any files being deleted.
There was a problem hiding this comment.
Old editing interface is not our custom thing, it's generated from the ORM by Flask-Admin.
No description provided.