-
-
Notifications
You must be signed in to change notification settings - Fork 925
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Truffle] Add an automatic check for missing lowerFixnum annotations.
* Rename check_ambiguous_arguments to check_dsl_usage as it's now more general.
- 9.4.12.0
- 9.4.11.0
- 9.4.10.0
- 9.4.9.0
- 9.4.8.0
- 9.4.7.0
- 9.4.6.0
- 9.4.5.0
- 9.4.4.0
- 9.4.3.0
- 9.4.2.0
- 9.4.1.0
- 9.4.0.0
- 9.3.15.0
- 9.3.14.0
- 9.3.13.0
- 9.3.12.0
- 9.3.11.0
- 9.3.10.0
- 9.3.9.0
- 9.3.8.0
- 9.3.7.0
- 9.3.6.0
- 9.3.5.0
- 9.3.4.0
- 9.3.3.0
- 9.3.2.0
- 9.3.1.0
- 9.3.0.0
- 9.2.21.0
- 9.2.20.1
- 9.2.20.0
- 9.2.19.0
- 9.2.18.0
- 9.2.17.0
- 9.2.16.0
- 9.2.15.0
- 9.2.14.0
- 9.2.13.0
- 9.2.12.0
- 9.2.11.1
- 9.2.11.0
- 9.2.10.0
- 9.2.9.0
- 9.2.8.0
- 9.2.7.0
- 9.2.6.0
- 9.2.5.0
- 9.2.4.1
- 9.2.4.0
- 9.2.3.0
- 9.2.2.0
- 9.2.1.0
- 9.2.0.0
- 9.1.17.0
- 9.1.16.0
- 9.1.15.0
- 9.1.14.0
- 9.1.13.0
- 9.1.12.0
- 9.1.11.0
- 9.1.10.0
- 9.1.9.0
- 9.1.8.0
- 9.1.7.0
Showing
5 changed files
with
97 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
truffle/src/main/java/org/jruby/truffle/builtins/LowerFixnumChecker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
* Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved. This | ||
* code is released under a tri EPL/GPL/LGPL license. You can use it, | ||
* redistribute it and/or modify it under the terms of the: | ||
* | ||
* Eclipse Public License version 1.0 | ||
* GNU General Public License version 2 | ||
* GNU Lesser General Public License version 2.1 | ||
*/ | ||
package org.jruby.truffle.builtins; | ||
|
||
import com.oracle.truffle.api.dsl.Cached; | ||
import com.oracle.truffle.api.dsl.NodeFactory; | ||
import com.oracle.truffle.api.dsl.Specialization; | ||
import com.oracle.truffle.api.frame.VirtualFrame; | ||
|
||
import java.lang.annotation.Annotation; | ||
import java.lang.reflect.Method; | ||
|
||
import org.jruby.truffle.core.array.ArrayUtils; | ||
import org.jruby.truffle.language.RubyNode; | ||
|
||
public class LowerFixnumChecker { | ||
|
||
public static boolean SUCCESS = true; | ||
|
||
public static void checkLowerFixnumArguments(NodeFactory<? extends RubyNode> nodeFactory, int initialSkip, CoreMethod methodAnnotation) { | ||
final Class<? extends RubyNode> nodeClass = nodeFactory.getNodeClass(); | ||
byte[] lowerArgs = null; | ||
for (Method specialization : nodeClass.getDeclaredMethods()) { | ||
if (specialization.isAnnotationPresent(Specialization.class)) { | ||
Class<?>[] argumentTypes = specialization.getParameterTypes(); | ||
int skip = initialSkip; | ||
if (argumentTypes.length > 0 && argumentTypes[0] == VirtualFrame.class) { | ||
skip++; | ||
} | ||
int end = argumentTypes.length; | ||
Annotation[][] annos = specialization.getParameterAnnotations(); | ||
for (int i = end - 1; i >= skip; i--) { | ||
boolean cached = false; | ||
for (Annotation anno : annos[i]) { | ||
cached |= anno instanceof Cached; | ||
} | ||
if (cached) { | ||
end--; | ||
} else { | ||
break; | ||
} | ||
} | ||
if (lowerArgs == null) { | ||
lowerArgs = new byte[end - skip]; | ||
} else { | ||
assert lowerArgs.length == end - skip; | ||
} | ||
for (int i = skip; i < end; i++) { | ||
Class<?> argumentType = argumentTypes[i]; | ||
if (argumentType == int.class) { | ||
lowerArgs[i - skip] |= 0b01; | ||
} else if (argumentType == long.class) { | ||
lowerArgs[i - skip] |= 0b10; | ||
} | ||
} | ||
} | ||
} | ||
|
||
// Verify against the lowerFixnum annotation | ||
final int[] lowerFixnum = methodAnnotation.lowerFixnum(); | ||
for (int i = 0; i < lowerArgs.length; i++) { | ||
boolean shouldLower = lowerArgs[i] == 0b01; // int without long | ||
if (shouldLower && !ArrayUtils.contains(lowerFixnum, i + 1)) { | ||
SUCCESS = false; | ||
System.err.println("Node " + nodeFactory.getNodeClass().getCanonicalName() + " should use lowerFixnum for argument " + (i + 1)); | ||
} | ||
} | ||
} | ||
} |