New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate truely top-level code from per-bootstrapping-stage code #21209
Conversation
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @obadz, @rardiol and @FRidh to be potential reviewers. |
Renaming files that everyone changes all the time is going to break almost every open PR or branch... |
Hmm git itself can easily deal with renamed files, but github isn't so clever. |
Is there an overview of what the desired structure of the top-level functions and repository layout is? In my opinion we should just move |
79e1df9
to
d45f03b
Compare
These are not stages, but collections / indexes of packages. I think What do you think? |
@nbp I like it! While yes I'll change this PR accordingly in a few minites, and also change the documentation in now-called |
- Truely top level stays in `pkgs/top-level` - Indices go in `pkgs/indices`
The command that did this was: (cd pkgs/indices; find -type f) | grep -v 'default\.nix' | cut -d/ -f2 | xargs -n1 -I % bash -c "git ls-files | xargs sed -i -e 's_top-level/%_indices/%_g'"
f92e2dc
to
e28853a
Compare
Not sure if I'm actually causing some sort of pythonic mass rebuild, or Travis was just having a bad day. |
Any update on this pull request? |
I think moving the package sets into their own folder is not a bad idea, although it's a pain when going through the history. if we would do this, then may as well create a new commit and PR. |
Motivation for this change
I think
top-level
was getting a but unwieldy. With this change:Things done
Gonna let Travis test this one
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)