Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2016.12.01 -> 2016.12.12 #21122

Merged
merged 1 commit into from Dec 13, 2016
Merged

Conversation

goetzst
Copy link
Contributor

@goetzst goetzst commented Dec 13, 2016

Motivation for this change

youtube-dl update
most notable changes:

  • [utils] Add common user agents map
  • [common] Recognize HLS manifests that contain video only formats
  • [socks] Fix error reporting
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@goetzst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Profpatsch, @peti and @AndersonTorres to be potential reviewers.

@Profpatsch
Copy link
Member

thanks!

@Profpatsch Profpatsch merged commit c1d60d8 into NixOS:master Dec 13, 2016
@goetzst goetzst deleted the youtube-dl branch December 13, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants