Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_{4_8,grsec_nixos}: patch to fix build failure #21118

Merged
merged 1 commit into from Dec 13, 2016
Merged

linux_{4_8,grsec_nixos}: patch to fix build failure #21118

merged 1 commit into from Dec 13, 2016

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 13, 2016

Motivation for this change

Frequent kernel build failures have plagued the release branch since upgrading from 4.8.12. My understanding is this issue as fixed a long time ago, but it appears to have opened up since. This patch should hopefully fix the issue.

Example problem: https://hydra.nixos.org/build/44743895/nixlog/1

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

crypto/rsa_helper.c:18:28: fatal error: rsapubkey-asn1.h: No such file or directory

cc @joachifm (grsec)
cc @fpletz (kernel)
cc @NeQuissimus (kernel)

I'd like to get this done before tomorrow so we can have prompt releases.

@grahamc
linux_{4_8,grsec_nixos}: patch to fix build failure
7a813d3 
crypto/rsa_helper.c:18:28: fatal error: rsapubkey-asn1.h: No such file or directory
@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm, @zohl and @edolstra to be potential reviewers.

@grahamc grahamc added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 13, 2016
@NeQuissimus NeQuissimus self-requested a review December 13, 2016 13:33
NeQuissimus
NeQuissimus approved these changes Dec 13, 2016
View reviewed changes
Copy link
Member

@NeQuissimus NeQuissimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grahamc
Copy link
Member Author

grahamc commented Dec 13, 2016

2 thumbs up and a LGTM is enough for me. I'll give @joachifm / @fpletz an hour or so more time to respond, then merge.

@grahamc
Copy link
Member Author

grahamc commented Dec 13, 2016

got a 👍 from joachifm on IRC.

@grahamc grahamc merged commit 01d022e into NixOS:master Dec 13, 2016
@grahamc grahamc deleted the fix-rsa-build-failure branch December 13, 2016 14:15
@dezgeg
Copy link
Contributor

dezgeg commented Dec 13, 2016

The commit that fixed this upstream only went to 4.9:

commit 57891633eeef60e732e045731cf20e50ee80acb4
Author: David Michael <david.michael@coreos.com>
Date:   Tue Nov 29 11:15:12 2016 -0800

    crypto: rsa - Add Makefile dependencies to fix parallel builds

I asked Greg KH to apply them to 4.8, so they will appear in the next 4.8.y release.

@joachifm
Copy link
Contributor

Looks like gregkh made good on that, the patch fails to apply to 4.8.15, at any rate :)

@vcunat
Copy link
Member

vcunat commented Dec 18, 2016 •
edited

Yes, in 4.8.15 changelog, picked as 762c9bb16fce.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@grahamc @mention-bot @dezgeg @joachifm @vcunat @NeQuissimus @samueldr