Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 0.14.12 -> 0.14.13 #20812

Merged
merged 1 commit into from
Nov 30, 2016
Merged

syncthing: 0.14.12 -> 0.14.13 #20812

merged 1 commit into from
Nov 30, 2016
+2 −2

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Nov 30, 2016

Motivation for this change

Recommended upgrade.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@jokogr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peterhoeg and @pshendry to be potential reviewers.

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Nov 30, 2016
@FRidh FRidh merged commit d6ffb97 into NixOS:master Nov 30, 2016
@FRidh
Copy link
Member

FRidh commented Nov 30, 2016 •
edited
Loading

should this be backported to stable?

@jokogr
Copy link
Contributor Author

jokogr commented Nov 30, 2016

@FRidh I see that release-16.09 has syncthing v0.14.7 and there is no security concern on the application since then, only minor releases have been made. Some bugfixes are quite convenient, though, so ping me if you wish me to backport it.

@FRidh
Copy link
Member

FRidh commented Nov 30, 2016

Some bugfixes are quite convenient, though, so ping me if you wish me to backport it.

That's up to you as maintainer.

@peterhoeg
Copy link
Member

peterhoeg commented Dec 1, 2016 •
edited
Loading

I would argue that if 0.14.7 is in stable, we should backport all 0.14.x versions as upstream recommends running the latest in the series. 0.15.x would be a different story.

@jokogr
Copy link
Contributor Author

jokogr commented Dec 1, 2016

Alright, let me do it then. @FRidh I cherry-pick the necessary commits and make a PR to release-16.09, right?

@FRidh
Copy link
Member

FRidh commented Dec 1, 2016

@jokogr yes, and use cherry-pick -x

@jokogr jokogr deleted the u/syncthing-0.14.13 branch December 1, 2016 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jokogr @mention-bot @FRidh @peterhoeg @pSub