make-system-tarball: create reproducible tarballs #21305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that archive members are added in sorted order with a fixed mtime. This allows `nix-build --check` to succeed (when building a tarball of a simple system configuration). We also remove env-vars which doesn't appear to do much apart from capture a bunch of store paths we probably don't want. This is an alternative to NixOS@4b78a5b
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @rbvermaa and @edolstra to be potential reviewers. |
dezgeg
reviewed
Dec 20, 2016
| tar cvJf $out/tarball/$fileName.tar.xz * $extraArgs | ||
| rm env-vars | ||
|
|
||
| tar --sort=name --mtime='1970-01-01' -cvJf $out/tarball/$fileName.tar.xz * $extraArgs |
There was a problem hiding this comment.
IIRC tar needs more magic options or it will capture the name of the build user: 3d50989
There was a problem hiding this comment.
Ah, you're right ofc, but on my end it says nixbld:nixbld which seems pretty predictable to me, so it's at least better than it was :)
There was a problem hiding this comment.
I guess user namespacing might now solve that by itself.
joachifm
added a commit
that referenced
this pull request
Jan 1, 2017
Ownership should now always be 0/0. Pointed out by @dezgeg at #21305 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to 4b78a5b