Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap GenericInstanceType in link if type vars don't have link #3693

Conversation

makenowjust
Copy link
Contributor

See Hash(K, V) doc:

2016-12-15 0 47 22

This pull request makes Enumerable({K, V}) wrap in link.

2016-12-15 0 52 06

@asterite
Copy link
Member

Awesome, thank you!! ❤️

It's so nice to see that you and others are starting to send PRs to the compiler's code, doc generator, etc. :-)

@asterite asterite merged commit 2022f7e into crystal-lang:master Dec 15, 2016
@RX14
Copy link
Contributor

RX14 commented Dec 15, 2016

@asterite I should learn compiler internals... Maybe I'll try and find some easy PRs over the holidays.

@asterite
Copy link
Member

@RX14 I plan to give a talk at Manas about how the compiler works, so more people there could start collaborating on the compiler. The talk will be in Spanish, but I'll take notes in English to prepare it, maybe do some slides. Once I do that I'll share it so others can jump into the compiler too. I believe there's a lot of room for improvements to the compiler, both in terms of code organization, readablity and performance.

@samueleaton
Copy link
Contributor

@asterite que bueno que hablo español, jaja. pero en verdad eso sería bien chévere. Por favor, hagalo 👍

@Sija
Copy link
Contributor

Sija commented Dec 20, 2016

This PR broke links rendering, see below (from docs generated for Number class):

image

@makenowjust makenowjust deleted the fix/wrap-generic-instance-type-in-link branch December 21, 2016 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants