Skip to content

idea-ultimate: 2016.2.2 -> 2016.2.5 #20771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 28, 2016

Motivation for this change
  • Let's have an updated, bug-fixed version of idea-ultimate
  • Jetbrains seems to remove any old version from download, so 2016.2.2 is no longer available to downlad, neither 2016.2.3, … Only 2016.2.5 is available for 2016.2.x versions. So idea-ultimate is currently no more installable on a 16.09 machine.

master is already using a new version 2016.3 that's why I'm opening it against 16.09 👼

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Update minor version of idea-ultimate in order to be able to build it.

Signed-off-by: Vincent Demeester vincent@sbr.pm

Sorry, something went wrong.

@mention-bot
Copy link

@vdemeester, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @edwtjo and @chris-martin to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

Hi, it would be better to cherry-pick the commit from the master branch to the stable branch, by doing the following:

$ git checkout release-16.09
$ git cherry-pick -x <commit-from-master>

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Nov 28, 2016
@vdemeester
Copy link
Member Author

@grahamc hum but master is using 2016.3, not sure we want to update to it or not ? 👼

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

Ah, you need to update the sha for the file:

trying https://download.jetbrains.com/idea/ideaIU-2016.2.5.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   154  100   154    0     0   1394      0 --:--:-- --:--:-- --:--:--  1439
100  486M  100  486M    0     0   104M      0  0:00:04  0:00:04 --:--:--  111M
output path ‘/nix/store/v9xin0v60qsxvb45r3n89iz93qg7342z-ideaIU-2016.2.5.tar.gz’ has sha256 hash ‘0g8v3fw3610gyi25x489vlb72200rgb3b4rwh0igr4w35gwdv91h’ when ‘1z5kr47n3hhx0ck163193lwlh76sykgchnq9hw1ihi25n6655j1z’ was expected

@vdemeester
Copy link
Member Author

@grahamc oh I can't believe I didn't commit that 😅 my bad, will update tomorrow morning first thing 👼

@grahamc
Copy link
Member

grahamc commented Nov 29, 2016

Sounds good. Please comment when you do :)

Update minor version of idea-ultimate in order to be able to build it.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@grahamc should be up-to-date 👼

@grahamc grahamc merged commit fc7d560 into NixOS:release-16.09 Nov 29, 2016
@vdemeester vdemeester deleted the idea-2016_2_5 branch November 29, 2016 20:37
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
idea-ultimate: 2016.2.2 -> 2016.2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants