matplotlib: Fix TkAgg #20775
Merged
matplotlib: Fix TkAgg #20775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aherrmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @datakurre and @FRidh to be potential reviewers. |
|
Is it working on master as expected? |
|
Note that I just pushed 4626857 (to fix evaluation when enabling TK backend with Python 3) so you will need to rebase. |
Support for TkAgg was broken due to the package `tk` being split into multiple outputs: The setup script was unable to locate the tk headers. This patch fixes that by passing the include path from `tk.dev` explicitly
aherrmann
force-pushed
the
pr_matplotlib_tkagg_stable
branch
from
cf44117
to
a6f741d
Compare
|
@FRidh Yes, it's working on master as expected. I just checked it with python 2.7 and 3.5. Thanks! And thanks for the heads-up. I've rebased the PR and tested it with python 2.7 and 3.5. |
|
@FRidh Thanks, it's working as expected. |
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
matplotlib: Fix TkAgg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Matplotlib with TkAgg was broken in 16.09 due to separate outputs in
tk.The matplotlib packages in
masterandrelease-16.09are so different that the changes in this PR and in #20774 are incompatible.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)CC: @FRidh @lovek323
Support for TkAgg was broken due to the package
tkbeing split intomultiple outputs: The setup script was unable to locate the tk headers.
This patch fixes that by passing the include path from
tk.devexplicitly