Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk-darwin: Fix libfreetype path #21089

Merged
merged 1 commit into from Dec 13, 2016
Merged

openjdk-darwin: Fix libfreetype path #21089

merged 1 commit into from Dec 13, 2016

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Dec 12, 2016 •
edited by LnL7

Motivation for this change

OpenJDK gives these errors when you don't have Xquartz installed on macOS:

Exception in thread "main" java.lang.UnsatisfiedLinkError: /nix/store/dfmh7qh5hc21wx4v5rxq6as5xjfcj2pq-openjdk-7u60b30/jre/lib/libfontmanager.dylib: dlopen(/nix/store/dfmh7qh5hc21wx4v5rxq6as5xjfcj2pq-openjdk-7u60b30/jre/lib/libfontmanager.dylib, 1): Library not loaded: /usr/X11/lib/libfreetype.6.dylib
  Referenced from: /nix/store/dfmh7qh5hc21wx4v5rxq6as5xjfcj2pq-openjdk-7u60b30/jre/lib/libfontmanager.dylib
  Reason: image not found

This patches openjdk to resolve to nixpkgs' freetype.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The freetype path was not working. This fixes it to use the nix
freetype version with install_name_tool.

@matthewbauer
openjdk-darwin: Fix libfreetype path
3bf0d36 
The freetype path was not working. This fixes it to use the nix
freetype version with install_name_tool.
@mention-bot
Copy link

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rbvermaa, @edolstra and @wkennington to be potential reviewers.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 12, 2016
@LnL7 LnL7 merged commit fd2cf18 into NixOS:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @mention-bot @LnL7