fcrackzip: init at 1.0 #21095
fcrackzip: init at 1.0 #21095
Conversation
|
forgot to commit all-packages.nix. Fixed |
| patches = [ ./fcrackzip_forkexec.patch ]; | ||
|
|
||
| buildInputs = [ ]; | ||
| # installFlags = "PREFIX=\${out}"; |
There was a problem hiding this comment.
Please remove this line if it's not needed.
| license = licenses.gpl2; | ||
| maintainers = with maintainers; [ nico202 ]; | ||
| platforms = with platforms; unix; | ||
| priority = 10; |
There was a problem hiding this comment.
Why the priority? Which binaries clash with other packages?
There was a problem hiding this comment.
fcrackzip/zipinfo clash with unzip/zipinfo
There was a problem hiding this comment.
Should I rename zipinfo to fcrackzip-zipinfo instead?
There was a problem hiding this comment.
That sounds useful! Please do, thanks! 👍
There was a problem hiding this comment.
@fpletz renamed (line 14)
| sha256 = "0l1qsk949vnz18k4vjf3ppq8p497966x4c7f2yx18x8pk35whn2a"; | ||
| }; | ||
|
|
||
| patches = [ ./fcrackzip_forkexec.patch ]; |
There was a problem hiding this comment.
Did you have to modify that patch? If not, can you use fetchpatch?
There was a problem hiding this comment.
I had to modify it a bit because it was a patch over a patched file
There was a problem hiding this comment.
If possible could you add a comment above the patches line explaining what the patch does?
nico202
force-pushed
the
fcrackzip
branch
3 times, most recently
from
085f9a8
to
2a485a5
Compare
| sha256 = "0l1qsk949vnz18k4vjf3ppq8p497966x4c7f2yx18x8pk35whn2a"; | ||
| }; | ||
|
|
||
| patches = [ ./fcrackzip_forkexec.patch ]; |
There was a problem hiding this comment.
If possible could you add a comment above the patches line explaining what the patch does?
patch adapted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430387