mendeley: 1.16.3 -> 1.17.7 - WIP #21093

FRidh · 2016-12-12T10:34:51Z

Motivation for this change

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Since 1.17 Mendeley uses Qt5. And its become massive, growing from 33 MB to 130 MB.

mention-bot · 2016-12-12T10:34:52Z

@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @badi, @bjornfor and @vcunat to be potential reviewers.

FRidh · 2016-12-12T11:19:42Z

@ttuegel any suggestions on how to make it find the vendored Qt5 libraries?

ttuegel · 2016-12-12T17:18:53Z

If you want to use the vendored libraries, you should remove Qt 5 from the buildInputs and either use patchelf to set the RPATH or make a wrapper to set LD_LIBRARY_PATH.

FRidh · 2016-12-12T18:22:53Z

@ttuegel okay, I will try to use the system libraries first. I'm surprised it links against so many xorg libraries.

FRidh · 2016-12-12T18:46:37Z

Getting close I think

This application failed to start because it could not find or load the Qt platform plugin "xcb".

I thought wrapQtProgram would solve finding plugins, but it didn't.

ttuegel · 2016-12-12T19:54:38Z

Right now your expression is still mixing our Qt with the vendor's. If you want to use our Qt, you need to change the library RPATH or LD_LIBRARY_PATH to point there, or else continue to use the vendor's libraries (and point RPATH or LD_LIBRARY_PATH there).

ttuegel

I would recommend sticking with the vendor's Qt libraries unless you know they won't work. It is generally a lot of trouble to keep Qt versions in sync because there is no binary compatibility between versions. Also, Qt has a commercial license which allows vendors to make incompatible downstream patches.

ttuegel · 2016-12-12T19:55:42Z

pkgs/applications/office/mendeley/default.nix

-,gcc, liborc, xorg, qt4, zlib
-, ...}:
+, alsaLib, dbus, expat, fontconfig, freetype, gcc, glib, libcap
+, liborc, libxml2, libxslt, nss, nspr, sqlite, xorg, qt55, zlib


You should use qt55.callPackage in all-packages.nix instead of importing qt55 into the expression. This ensures that everything which depends on Qt 5 is built with the same version.

ttuegel · 2016-12-12T19:56:08Z

pkgs/applications/office/mendeley/default.nix

    zlib
+    qt55.qtbase


Along the same lines as above, use qtbase and qtdeclarative here.

ttuegel · 2016-12-12T19:56:33Z

pkgs/applications/office/mendeley/default.nix

@@ -51,7 +72,11 @@ stdenv.mkDerivation {
    patchelf --set-interpreter $interpreter $out/bin/mendeleydesktop

    librarypath="${stdenv.lib.makeLibraryPath deps}:$out/lib:$out/lib/qt"


This still points to the vendor's Qt libraries.

FRidh · 2016-12-29T16:50:33Z

I got a bit further using the vendored libraries. It doesn't work quite yet though

$ nix-shell -p mendeley -I nixpkgs=.  --run mendeleydesktop
xkbcommon: ERROR: failed to add default include path /usr/share/X11/xkb
Qt: Failed to create XKB context!
Use QT_XKB_CONFIG_ROOT environmental variable to provide an additional search path, add ':' as separator to provide several search paths and/or make sure that XKB configuration data directory contains recent enough contents, to update please see http://cgit.freedesktop.org/xkeyboard-config/ .
QXcbIntegration: Cannot create platform OpenGL context, neither GLX nor EGL are enabled
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QObject::connect: Cannot connect (null)::stateChanged(QNetworkSession::State) to QNetworkReplyHttpImpl::_q_networkSessionStateChanged(QNetworkSession::State)
QSslSocket: cannot call unresolved function SSLv23_client_method
QSslSocket: cannot call unresolved function SSL_CTX_new
QSslSocket: cannot call unresolved function SSL_library_init
QSslSocket: cannot call unresolved function ERR_get_error
QSslSocket: cannot call unresolved function ERR_get_error
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
Qt WebEngine Plugins directory not found. Trying fallback directory... Plugins as for example video codecs MAY NOT work.
Crash handler wrote minidump /home/freddy/.local/share/data/Mendeley Ltd./Mendeley Desktop/minidumps/03c3c4b4-51d5-5777-6e569cb4-74af8af5.dmp
/run/user/1000/nix-shell.G__yfF/rc: line 1: 14428 Segmentation fault      mendeleydesktop

FRidh · 2017-02-22T13:35:23Z

@ttuegel any suggestions on how to get this working?

ttuegel · 2017-02-23T18:49:05Z

It looks like the vendored libraries have hardcoded paths, in particular

xkbcommon: ERROR: failed to add default include path /usr/share/X11/xkb

It looks like you will have to substitute a xkbcommon build from Nixpkgs, at least.

FRidh · 2017-02-26T14:08:44Z

I see now I forgot to update the PR. I've added libxkbcommon and set a path for it as well.

$ $(nix-build -A mendeley)/bin/mendeleydesktop
QXcbIntegration: Cannot create platform OpenGL context, neither GLX nor EGL are enabled
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QObject::connect: Cannot connect (null)::stateChanged(QNetworkSession::State) to QNetworkReplyHttpImpl::_q_networkSessionStateChanged(QNetworkSession::State)
QSslSocket: cannot call unresolved function SSLv23_client_method
QSslSocket: cannot call unresolved function SSL_CTX_new
QSslSocket: cannot call unresolved function SSL_library_init
QSslSocket: cannot call unresolved function ERR_get_error
QSslSocket: cannot call unresolved function ERR_get_error
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QSslSocket: cannot call unresolved function d2i_X509
QLayout: Attempting to add QLayout "" to ToolBarActionWidget "", which already has a layout
QLayout: Attempting to add QLayout "" to ToolBarActionWidget "", which already has a layout
Qt WebEngine Plugins directory not found. Trying fallback directory... Plugins as for example video codecs MAY NOT work.
Crash handler wrote minidump /home/freddy/.local/share/data/Mendeley Ltd./Mendeley Desktop/minidumps/0506ac28-1a2e-2bd5-70e6449e-59e666cc.dmp
Segmentation fault

ttuegel · 2017-02-27T13:57:08Z

That looks to me like missing OpenSSL. If that's not it, try searching for the symbol names.

FRidh · 2017-03-07T09:22:41Z

Merged #23563

FRidh added 2.status: work-in-progress 6.topic: qt/kde 8.has: package (update) labels Dec 12, 2016

FRidh force-pushed the mendeley branch from bfabf82 to 4d6b204 Compare December 12, 2016 18:45

ttuegel requested changes Dec 12, 2016

View reviewed changes

FRidh force-pushed the mendeley branch from 4d6b204 to fbcb564 Compare December 29, 2016 16:49

FRidh force-pushed the mendeley branch from fbcb564 to 2dab6f2 Compare February 13, 2017 16:59

FRidh changed the title ~~mendeley: 1.16.3 -> 1.17.6 - WIP~~ mendeley: 1.16.3 -> 1.17.7 - WIP Feb 13, 2017

mendeley: 1.16.3 -> 1.17.6

c23d7dd

FRidh force-pushed the mendeley branch from 2dab6f2 to c23d7dd Compare February 26, 2017 14:07

FRidh mentioned this pull request Mar 7, 2017

mendeley: 1.16.3 -> 1.17.8, multiple improvements #23563

Merged

7 tasks

FRidh closed this Mar 7, 2017

FRidh deleted the mendeley branch March 7, 2017 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mendeley: 1.16.3 -> 1.17.7 - WIP #21093

mendeley: 1.16.3 -> 1.17.7 - WIP #21093

FRidh commented Dec 12, 2016 •

edited

mention-bot commented Dec 12, 2016

FRidh commented Dec 12, 2016

ttuegel commented Dec 12, 2016

FRidh commented Dec 12, 2016

FRidh commented Dec 12, 2016

ttuegel commented Dec 12, 2016

ttuegel left a comment

ttuegel Dec 12, 2016

ttuegel Dec 12, 2016

ttuegel Dec 12, 2016

FRidh commented Dec 29, 2016

FRidh commented Feb 22, 2017

ttuegel commented Feb 23, 2017

FRidh commented Feb 26, 2017

ttuegel commented Feb 27, 2017

FRidh commented Mar 7, 2017

		@@ -51,7 +72,11 @@ stdenv.mkDerivation {
		patchelf --set-interpreter $interpreter $out/bin/mendeleydesktop

		librarypath="${stdenv.lib.makeLibraryPath deps}:$out/lib:$out/lib/qt"

mendeley: 1.16.3 -> 1.17.7 - WIP #21093

mendeley: 1.16.3 -> 1.17.7 - WIP #21093

Conversation

FRidh commented Dec 12, 2016 • edited

Motivation for this change

Things done

mention-bot commented Dec 12, 2016

FRidh commented Dec 12, 2016

ttuegel commented Dec 12, 2016

FRidh commented Dec 12, 2016

FRidh commented Dec 12, 2016

ttuegel commented Dec 12, 2016

ttuegel left a comment

Choose a reason for hiding this comment

ttuegel Dec 12, 2016

Choose a reason for hiding this comment

ttuegel Dec 12, 2016

Choose a reason for hiding this comment

ttuegel Dec 12, 2016

Choose a reason for hiding this comment

FRidh commented Dec 29, 2016

FRidh commented Feb 22, 2017

ttuegel commented Feb 23, 2017

FRidh commented Feb 26, 2017

ttuegel commented Feb 27, 2017

FRidh commented Mar 7, 2017

FRidh commented Dec 12, 2016 •

edited