-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SDL samples on linux #3678
Fix SDL samples on linux #3678
Conversation
With your changes I'm able to run the examples, but running
|
Interesting. All it did for me is add performance. Testing on fresh VM install.
Did these samples work for you without my changes? I have no way to test on a mac right now. |
No, they were not working. They are working with your changes in my linux machine (my mac runs linux, not osx) with the exception of |
Seems like you are using your locally compiled crystal, which seems to have some kind of problem.
|
This is a small change, what is taking so long? Broken samples are rather discouraging for people new to crystal. |
I think it's better if we remove these samples and move them to, maybe, https://github.com/ysbaddaden/sdl.cr |
It's taking some time because:
Last but not least: the samples are for SDL 1.2, not SDL 2 as far as I know, and both versions sre quite different. |
I think the Crystal-lang team have done a great job and more than deserve some time off to spend w/ family this holiday season! Merry [belated] Christmas and Happy New Year! |
Indeed, happy new year! |
Closing this. Samples on master still exist and fail, but i see no interest in this PR. |
None of them were working for me on debian. Works as intended with these changes.