Skip to content

flow: 0.34.0 -> 0.36.0 #20689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2016
Merged

flow: 0.34.0 -> 0.36.0 #20689

merged 1 commit into from
Nov 28, 2016
+2 −2

Conversation

frontsideair
Copy link
Contributor

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@frontsideair, thanks for your PR! By analyzing the history of the files in this pull request, we identified @puffnfresh, @msteen and @despairblue to be potential reviewers.

@vbgl
Copy link
Contributor

vbgl commented Nov 25, 2016

This does not build on darwin.

First error: typedef redefinition with different types ('uint64_t' (aka 'unsigned long long') vs 'unsigned long') It can be fixed by using OCaml-4.02.

Next error:

cd _build/src/third-party/lz4/ && ocamlopt -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/hack/fsevents -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/hack/heap -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/hack/hhi -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/hack/utils -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/src/embedded -ccopt -I -ccopt /private/var/folders/sd/7cvw05g535n06lgy9fm_lcrm0000gp/T/nix-build-flow-0.36.0.drv-1/flow-v0.36.0-src/_build/src/third-party/lz4  -ccopt -DNO_SQLITE3 -c lz4hc.c
lz4hc.c:65:10: fatal error: 'lz4.c' file not found

This one may be an upstream issue rather than a packaging one.

@Mic92
Copy link
Member

Mic92 commented Nov 27, 2016

Using a newer version of ocaml would not hurt, if it fixes darwin support.

@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

@vbgl does the current version in master build on darwin?

@vbgl
Copy link
Contributor

vbgl commented Nov 28, 2016

No it does not. Same errors. Sorry for the noise.

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Nov 28, 2016
@grahamc
Copy link
Member

grahamc commented Nov 28, 2016

That is okay, @vbgl. I'm wanting to be careful about causing regressions there.

@grahamc grahamc merged commit 8088ad7 into NixOS:master Nov 28, 2016
@frontsideair
Copy link
Contributor Author

Sorry I couldn't contribute here. Thanks for the merge.

@frontsideair frontsideair deleted the flow-34-36 branch November 28, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frontsideair @mention-bot @vbgl @Mic92 @grahamc @pSub