nixos/collectd: Fix syntax error on some hostnames. #20694
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, hostnames that e.g. end in digits will cause syntax errors for collectd.
|
@MostAwesomeDude, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @fpletz and @bjornfor to be potential reviewers. |
fpletz
added
0.kind: bug
|
Thanks! 🍻 |
fpletz
pushed a commit
that referenced
this pull request
Nov 24, 2016
Without this, hostnames that e.g. end in digits will cause syntax errors for collectd. (cherry picked from commit 27f1def)
samueldr
removed
the
9.needs: port to stable
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Without this, hostnames that e.g. end in digits will cause syntax errors for collectd. (cherry picked from commit 27f1def)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to monitor a host with the hostname "helper-us-west1". This hostname causes syntax errors if unquoted.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Tested on live machines.
Without this, hostnames that e.g. end in digits will cause syntax errors for
collectd.