less: Adjust version after disappearance of source package #20702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage. This is a fix for the current package source file http://www.greenwoodsoftware.com/less/less-483.tar.gz not being available anymore. We bump the less version back to 481, and adjust the source package hash accordingly. This is a (slight) downgrade from 483 as opposed to an upgrade since a) 481 is the current Recommended version by http://www.greenwoodsoftware.com/less/download.html b) Upstream is unreliable about keeping experimental versions around.
|
@sh01, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @edolstra and @mbakke to be potential reviewers. |
|
Alternatively, upgrade to 487, but I agree it makes sense to go with what upstream recommends. This effectively reverts 473e5a4 Also, please note that the contribution guidelines mandate that commits that change packages have subjects of the form |
sh01
changed the title
|
I'll recreate this with a commit that has the right subject. Thanks! |
|
Ah, I didn't mean for you to close the PR :) You can force push the PR branch to update it. |
|
Oh whoops. I'll try that next time; as it is, I've re-opened this as #20703 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Change less version since the current source http://www.greenwoodsoftware.com/less/less-483.tar.gz has become unavailable, making it impossible to build this.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This is a fix for the current package source file
http://www.greenwoodsoftware.com/less/less-483.tar.gz
not being available anymore.
We bump the less version back to 481, and adjust the source package hash
accordingly. This is a (slight) downgrade from 483 as opposed to an
upgrade since
a) 481 is the current Recommended version by http://www.greenwoodsoftware.com/less/download.html
b) Upstream is unreliable about keeping experimental versions around.