R: 3.2.4 -> 3.3.2 #20704
Closed
R: 3.2.4 -> 3.3.2 #20704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TravisWhitaker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @peti and @datakurre to be potential reviewers. |
|
Have you reported those test failures upstream? |
|
I wasn't able to find a relevant bug upstream, and I'd like to build some additional insight as to exactly why these simple-seeming tests fail before reporting. That said, perhaps that's better left to the upstream maintainers. Unfortunately I've been rather busy this past week. I should be able to provide a more comprehensive report to upstream in the next few days. |
|
If I had to guess, I'd speculate that the tests are failing because we compile with |
|
Fixed with #22817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates R from 3.2.4 to 3.3.2
Unfortunately it seems as though the tests are broken upstream; I can't seem to get them to pass outside of the Nix store either. The failure seems to be related to dependency on the "MASS" package, which isn't available in the build environment (and the tests don't seem to attempt to install it). R-3.3.1 from the Gentoo ebuild fails in the same way.
Despite this the resulting interpreter seems to work, and reverse dependencies build and pass their tests.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)