CIFS improvements #20691
Merged
CIFS improvements #20691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this ./configure symptom: configure: WARNING: talloc.h not found, consider installing libtalloc-devel. Disabling cifs.upcall. and is needed to (eventually) fix CIFS + DFS kernel mount on NixOS.
The plan is to fix mounting DFS shares on NixOS (for which some of these options are needed), but I figured it might be a good idea to enable all CONFIG_CIFS_* like Fedora 24 and Ubuntu 16.04 while at it. Ubuntu even has CONFIG_CIFS_SMB311, but as Fedora do not, I left it out. Mounting DFS shares still doesn't work; need to configure cifs.upcall and /etc/request-key.conf. Until then, using GVFS as a workaround.
It was useful in tracking down CIFS + DFS issue, and it's apparently enabled by default in two major distros.
|
@bjornfor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @zohl to be potential reviewers. |
fpletz
approved these changes
Nov 24, 2016
grahamc
approved these changes
Nov 28, 2016
|
I'll merge once I get to re-test this on top of latest master. |
|
@bjornfor: ping? |
|
I've been busy with other things. I don't mind if you merge if you don't want to wait for me. |
|
I see two good reviews, so if some of you tested it, I don't think there's any reason to wait. I personally don't truly care; I was just passing tickets without any change for several days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Kernel CIFS+DFS mounts are not working on NixOS. This branch started out with the intention of fully fixing it, but my priorities have changed and now I don't have concrete plans to continue working on it. But I think the current set of changes are good and I hope the NixOS community agrees (so we can merge it).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)