-
-
Notifications
You must be signed in to change notification settings - Fork 925
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Truffle] Put ConditionVariable back in Ruby.
* Using Object#wait() or Condition#await() has the problem that it can only be interrupted by Thread#interrupt() if it can acquire the monitor back. Otherwise, it stays stuck and in the case we are trying to get to a guest-language safepoint, deadlocks. The problem comes from the fact that the monitor must be hold while invoking the safepoint as we need to prevent another thread to notify() while we are interrupted and not in wait(). Since the monitor can be held during the safepoint, then interrupts sent by the safepoint are not unblocking threads waiting on the same condition with wait(), as they would need to acquire the lock that only one of the thread that got unblocked holds. * The logic in Ruby is clearer and relies on Mutex#sleep and Thread#wakeup, which are simpler primitives and easier to implement.
- 9.4.12.0
- 9.4.11.0
- 9.4.10.0
- 9.4.9.0
- 9.4.8.0
- 9.4.7.0
- 9.4.6.0
- 9.4.5.0
- 9.4.4.0
- 9.4.3.0
- 9.4.2.0
- 9.4.1.0
- 9.4.0.0
- 9.3.15.0
- 9.3.14.0
- 9.3.13.0
- 9.3.12.0
- 9.3.11.0
- 9.3.10.0
- 9.3.9.0
- 9.3.8.0
- 9.3.7.0
- 9.3.6.0
- 9.3.5.0
- 9.3.4.0
- 9.3.3.0
- 9.3.2.0
- 9.3.1.0
- 9.3.0.0
- 9.2.21.0
- 9.2.20.1
- 9.2.20.0
- 9.2.19.0
- 9.2.18.0
- 9.2.17.0
- 9.2.16.0
- 9.2.15.0
- 9.2.14.0
- 9.2.13.0
- 9.2.12.0
- 9.2.11.1
- 9.2.11.0
- 9.2.10.0
- 9.2.9.0
- 9.2.8.0
- 9.2.7.0
- 9.2.6.0
- 9.2.5.0
- 9.2.4.1
- 9.2.4.0
- 9.2.3.0
- 9.2.2.0
- 9.2.1.0
- 9.2.0.0
- 9.1.17.0
- 9.1.16.0
- 9.1.15.0
- 9.1.14.0
- 9.1.13.0
- 9.1.12.0
- 9.1.11.0
- 9.1.10.0
- 9.1.9.0
- 9.1.8.0
- 9.1.7.0
Showing
6 changed files
with
100 additions
and
220 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 0 additions & 32 deletions
32
truffle/src/main/java/org/jruby/truffle/core/mutex/ConditionVariableLayout.java
This file was deleted.
Oops, something went wrong.
167 changes: 0 additions & 167 deletions
167
truffle/src/main/java/org/jruby/truffle/core/mutex/ConditionVariableNodes.java
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
truffle/src/main/java/org/jruby/truffle/core/mutex/ConditionVariableObject.java
This file was deleted.
Oops, something went wrong.