Skip to content

heist haskell package: fixed missing test dependency #20832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

greyson
Copy link
Contributor

@greyson greyson commented Dec 1, 2016

Motivation for this change

Heist would not install.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • [ x ] Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nomadium Miguel Landaeta
@pjones
Copy link
Contributor

pjones commented Dec 1, 2016

It looks like this will be fixed upstream: snapframework/heist#98.

I am under the impression that hackage-packages.nix is a generated file. If that is the case we'll need this to be fixed some other way.

This is how I got around the issue temporarily:

haskell.packages.ghc7103.ghcWithPackages (p: 
  let goodheist = pkgs.haskell.lib.dontCheck p.heist;
      goodsnap  = p.snap.override { heist = goodheist; };
  in [ goodsnap ]
)

Edit: Updated upstream note and added some Nix code.

@LnL7
Copy link
Member

LnL7 commented Dec 2, 2016

This file is indeed generated, configuration-common.nix is the correct place to add overrides like this.
You can use the overrideCabal to override attributes like the testToolDepends.

@vcunat vcunat added the 2.status: work-in-progress This PR isn't done label Dec 9, 2016
@domenkozar
Copy link
Member

Superseeded by ad489ce

@domenkozar domenkozar closed this Jan 3, 2017
@greyson greyson deleted the haskell.heist branch March 7, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants