RubyHash's compare_by_identify Java method naming is confusing #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hopefully this is internal - and no one actually cares to have it the old way. but just in case, here's a PR ... |
`Hash#compare_by_identity` is more of a writer (does call a setter) ... looks esp. weird since there's a java get/setCompareByIdentity
kares
force-pushed
the
confusing-naming
branch
from
a5acf19
to
8abd0f1
Compare
|
Indeed, this confused me quite a bit while looking at |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash#compare_by_identityis more of a writer (does call a setter)... looks esp. weird since there's a java get/setCompareByIdentity