Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.parsedatetime: update #21156

Merged
merged 1 commit into from Jan 5, 2017
Merged

pythonPackages.parsedatetime: update #21156

merged 1 commit into from Jan 5, 2017

Conversation

schneefux
Copy link
Contributor

Motivation for this change

Added metadata, disabled tests so parsedatetime builds again

Building the parsedatetime python module failed at the tests with the error

======================================================================
FAIL: testEndOfPhrases (parsedatetime.tests.TestStartTimeFromSourceTime.test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/timo/nix-build-python3.5-parsedatetime-1.5.drv-0/parsedatetime-1.5/parsedatetime/tests/TestStartTimeFromSourceTime.py", line 41, in testEndOfPhrases
    self.assertExpectedResult(self.cal.parse('eom',         start), (target, 2))
  File "/tmp/timo/nix-build-python3.5-parsedatetime-1.5.drv-0/parsedatetime-1.5/parsedatetime/tests/__init__.py", line 40, in decoratedComparator
    self.fail(failureMessage % (result, check))
AssertionError: Result does not match target value

        Result:
        ((2017, 12, 31, 13, 14, 15, 3, 348, -1), 2)

        Expected:
        (time.struct_time(tm_year=2016, tm_mon=12, tm_mday=31, tm_hour=13, tm_min=14, tm_sec=15, tm_wday=5, tm_yday=366, tm_isdst=-1), 2)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@schneefux, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented Dec 17, 2016

Let's not disable tests because one test fails but solve it in a better way.

First of all, is the test failure correct? What does upstream say about it? Is there a fix for it?
If this road doesn't work out we can disable individual tests, with the exact method depending on the test runner.

@schneefux
Copy link
Contributor Author

The NixPkg parsedatetime version is 1.5, upstream is at 2.1.
The eom check fails in December. This was fixed in 2.0 (bear/parsedatetime#146).
I updated the package.

@FRidh
Copy link
Member

FRidh commented Dec 17, 2016

Good idea. Did you check with say nox-review whether dependents still build?

@schneefux
Copy link
Contributor Author

nix-shell -p nox --run "nox-review pr 21156" exited without errors, so I assume
python27Packages.agate-dbf certbot python27Packages.jrnl python27Packages.agate-excel python35Packages.parsedatetime python27Packages.parsedatetime python27Packages.agate built fine.

@FRidh FRidh self-assigned this Jan 4, 2017
@FRidh
Copy link
Member

FRidh commented Jan 5, 2017

okay, thank you.

@FRidh FRidh merged commit 6ab2e40 into NixOS:master Jan 5, 2017
@FRidh FRidh changed the title pythonPackages.parsedatetime: disable tests to fix the build pythonPackages.parsedatetime: update Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schneefux @mention-bot @FRidh