[Truffle] Fix optional assignment specs #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts with ||= assignments.
…nts with &&= assignments.
…nts with operator assignments.
chrisseaton
approved these changes
Dec 2, 2016
eregon
reviewed
Dec 2, 2016
| return visitOpAsgnAndNode(node, node.getFirstNode().accept(this), node.getSecondNode().accept(this)); | ||
| } | ||
|
|
||
| private RubyNode visitOpAsgnAndNode(ParseNode node, RubyNode lhs, RubyNode rhs) { |
There was a problem hiding this comment.
I think it's clearer to give it another name like translateOpAsgnAndNode.
eregon
reviewed
Dec 2, 2016
|
|
||
| default: { | ||
| final RubySourceSection sourceSection = translate(node.getPosition()); | ||
| final RubyCallNodeParameters callParameters = new RubyCallNodeParameters(context, sourceSection.toSourceSection(source), lhs, node.getOperator(), null, new RubyNode[] { rhs }, false, true, false, false, false); |
There was a problem hiding this comment.
There is a slightly shorter version if the last 3 boolean are false for RubyCallNodeParameters.
There was a problem hiding this comment.
Thanks. I missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the remaining optional variable assignment specs. I think what I did makes sense, but I'd appreciate at least another pair of eyes looking over the changes.
@jruby/truffle