Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omake: update to 0.10.1 #20867

Merged
merged 4 commits into from
Dec 9, 2016
Merged

omake: update to 0.10.1 #20867

merged 4 commits into from
Dec 9, 2016

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Dec 2, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dguibert, @craff and @bcdarwin to be potential reviewers.

@vcunat
Copy link
Member

vcunat commented Dec 9, 2016

Any reason why you haven't merged it yourself?

@vbgl
Copy link
Contributor Author

vbgl commented Dec 9, 2016

I waited a little bit just in case someone had a comment… I am not completely confident about the teyjus update.

Let’s merge and see.

@vbgl vbgl merged commit 4423457 into NixOS:master Dec 9, 2016
@FlorentBecker
Copy link
Contributor

isn't teyjus broken now?

@vbgl
Copy link
Contributor Author

vbgl commented Dec 18, 2016

Thanks for the report. teyjus indeed fails to build. As I don’t understand the error, I’ve reverted two commits such that teyjus is kept at the older version and still use omake-0.9.8.6-rc1.

@vbgl vbgl deleted the omake-0.10.1 branch October 2, 2017 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @mention-bot @vcunat @FlorentBecker