Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make builds cross compile to correct target for x86_64-apple-darwin16.1.0 #3627

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

rdp
Copy link
Contributor

@rdp rdp commented Dec 2, 2016

Without this you get:

$ ./bin/crystal build -o .build/crystal_cyg src/compiler/crystal.cr --target x86_64-apple-darwin16.1.0
Using compiled compiler at .build/crystal
using path x86_64-apple-darwin16.1.0
Error while requiring "prelude"

in src/prelude.cr:15: while requiring "exception"

require "exception"
^

in src/exception.cr:1: while requiring "callstack"

require "callstack"
^

in src/callstack.cr:1: while requiring "c/dlfcn": can't find file 'c/dlfcn' relative to '/Users/packrd/dev/ruby/downloads/crystal/src'

require "c/dlfcn"
^

…(--target) x86_64-apple-darwin16.1.0 which my sierra box with llvm 3.9 advertises
@asterite
Copy link
Member

asterite commented Dec 3, 2016

I think this looks good. @ysbaddaden what do you think?

@ysbaddaden
Copy link
Contributor

I suppose it's OK. I don't know what are the actual host target on macOS nowadays.

What's weird is that this currently work on Darwin, where we use the default LLVM host target, which obviously don't use this triple.

But maybe we have a wrong assumption of the actual LLVM host target on macOS?

@asterite asterite merged commit c5e1388 into crystal-lang:master Dec 12, 2016
@asterite
Copy link
Member

@rdp Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants