sisco.lv2: init at 0.7.0 #20868
Merged
sisco.lv2: init at 0.7.0 #20868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added maintainer `e-user`
zimbatm
reviewed
Dec 3, 2016
| robtkVersion = "80a2585253a861c81f0bfb7e4579c75f5c73af89"; | ||
| robtkName = "robtk-${robtkVersion}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
for github archives it's better to use fetchFromGitHub
|
That change didn't go as smooth at it ought to be, but there you go. |
|
The CI error looks completely bogus to me. |
zimbatm
reviewed
Dec 9, 2016
|
|
||
| let | ||
| name = "sisco.lv2-${version}"; | ||
| name = "sisco.lv2-${src.rev}"; |
There was a problem hiding this comment.
the previous change was correct. The version shouldn't be prefixed with "v", it breaks the update detection otherwise.
|
Almost there! |
|
What's left to do, now? |
|
All good now :) |
bartoldeman
pushed a commit
to ComputeCanada/nixpkgs
that referenced
this pull request
Apr 12, 2017
* sisco.lv2: init at 0.7.0 Also added maintainer `e-user` * Use fetchFromGitHub and adapt accordingly * Use `version` instead of `src.rev` in name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I needed sisco.lv2 myself for analyzing waveforms.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Also added maintainer
e-user