minikube: init at 0.13.1 #20937
minikube: init at 0.13.1 #20937
Conversation
|
duplicate of #20819, but this one is newer. |
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://storage.googleapis.com/minikube/releases/v${version}/minikube-${arch}"; |
There was a problem hiding this comment.
oh, the other pull request from @offlinehacker builds from source, so I would actually prefer it in this case. Maybe you can test if his works also works on darwin and add yourself as a second maintainer (for osx)
There was a problem hiding this comment.
I’ll do that, then I’ll post updates.
There was a problem hiding this comment.
I can’t build it on macOS. I get error: attribute ‘glibc’ missing.
There was a problem hiding this comment.
localkube is most probably a problem, as it needs to be static elf x64 binary.
There was a problem hiding this comment.
In that particular case i find your pull request better, as I can't see an easy way how to do such build on Darwin, as it needs to be static linux binary, and nix can't do mixed architecture builds. While vm support that nix has could solve this, nix does not support other virtualization as KVM, so this is also no go.
|
Question, I see you don't do patchelf, is minikube statically built? |
|
@offlinehacker Yes, it does not require patchelf. |
|
OK, I will test it tomorrow and then we can merge your pull request.
…On Wed, Dec 7, 2016, 2:45 AM Rommel M. Martinez ***@***.***> wrote:
@offlinehacker <https://github.com/offlinehacker> Yes, it does not
require patchelf.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20937 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjvS0dgb4HGdtI_FReo01W5SRjondzFks5rFg_FgaJpZM4LE7XX>
.
|
|
Ok! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)