Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libupnp: 1.6.20 -> 1.6.21 #21317

Closed
wants to merge 1 commit into from
Closed

libupnp: 1.6.20 -> 1.6.21 #21317

wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 20, 2016 •
edited

Motivation for this change

I'm not super familiar with sourceforge, I hope this is not a temporary url.

/cc @grahamc

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @grahamc, @fpletz and @dezgeg to be potential reviewers.

@LnL7 LnL7 mentioned this pull request Dec 20, 2016
Closed
33 tasks
@bachp
Copy link
Member

bachp commented Dec 20, 2016

Wouldn't it be better to fetch via git? I think that is supported by nix?

@LnL7
Copy link
Member Author

LnL7 commented Dec 20, 2016

That will pull in the entire history, we generally prefer an url. But I can switch if this doesn't work properly.

@copumpkin
Copy link
Member

Fetching with git is far slower than fetching prebundled archives, since it's O(all of repo history) rather O(requested revision). Having said that, I don't know if the sourceforge link is stable so we might be stuck with it.

@LnL7
Copy link
Member Author

LnL7 commented Dec 20, 2016

The sha in the url does match the commit of the release-1.6.21 tag [07c03d]

@grahamc
Copy link
Member

grahamc commented Dec 20, 2016

Looks like it might be available via github: https://github.com/mrjimenez/pupnp/issues/14

@grahamc
Copy link
Member

grahamc commented Dec 21, 2016 via email

@grahamc grahamc closed this Dec 21, 2016
@grahamc
Copy link
Member

grahamc commented Dec 21, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LnL7 @mention-bot @bachp @copumpkin @grahamc