Compiler: don't match splat restriction by default. Fixes #3698

crystal-lang · Dec 15, 2016 · 0c6cd7a · 0c6cd7a
1 parent 02d4db3
commit 0c6cd7a
Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/spec/compiler/semantic/restrictions_spec.cr b/spec/compiler/semantic/restrictions_spec.cr
@@ -397,4 +397,14 @@ describe "Restrictions" do
       foo(Parent || Child)
       )) { types["Parent"].metaclass.virtual_type! }
   end
+
+  it "doesn't crash on invalid splat restriction (#3698)" do
+    assert_error %(
+      def foo(arg : *String)
+      end
+
+      foo(1)
+      ),
+      "no overload matches"
+  end
 end
diff --git a/src/compiler/crystal/semantic/restrictions.cr b/src/compiler/crystal/semantic/restrictions.cr
@@ -426,6 +426,10 @@ module Crystal
       nil
     end
 
+    def restrict(other : Splat, context)
+      nil
+    end
+
     def restrict(other : ASTNode, context)
       raise "Bug: unsupported restriction: #{self} vs. #{other}"
     end