Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup description of ripgrep. #21193

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Fixup description of ripgrep. #21193

merged 1 commit into from
Dec 16, 2016

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Dec 15, 2016

Motivation for this change

Pretty-up the english.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@tsaeger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tailhook and @bennofs to be potential reviewers.

@grahamc grahamc merged commit 96c05c1 into NixOS:master Dec 16, 2016
@grahamc
Copy link
Member

grahamc commented Dec 16, 2016

Ack, I merged but didn't intend to. The nit-pick is the commit message should have been formatted as ripgrep: fixup description. Keep that in mind for next time.

@tsaeger
Copy link
Contributor Author

tsaeger commented Dec 16, 2016

@grahamc sorry about the commit message format, I'll be sure to make it conform next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants