New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awslogs #20921
Add awslogs #20921
Conversation
|
||
meta = { | ||
homepage = https://github.com/jorgebastida/awslogs; | ||
description = "AWS CloudWatch logs for Humans"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to maintain this package?
@@ -1544,10 +1544,10 @@ in { | |||
|
|||
awslogs = buildPythonPackage rec { | |||
name = "awslogs-${version}"; | |||
version = "0.5"; | |||
version = "0.7"; | |||
src = pkgs.fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchFromGithub is prefered here.
This is not a library but a command line application, right? We put those package usually outside of python-packages.nix. Otherwise looks good to me. |
Ah, got it. Is this better? Or should it go into |
yeah, put it into |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)