Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urbit: 2016-06-02 -> 0.4 #20922

Merged
merged 2 commits into from Dec 13, 2016
Merged

urbit: 2016-06-02 -> 0.4 #20922

merged 2 commits into from Dec 13, 2016

Conversation

dbrock
Copy link
Contributor

@dbrock dbrock commented Dec 5, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@dbrock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brainrape, @FRidh and @wkennington to be potential reviewers.


stdenv.mkDerivation rec {

name = "urbit-${version}";
version = "2016-06-02";
version = "2016-11-01";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a reasonable released version of this tool: https://github.com/urbit/urbit/releases/tag/v0.4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbrock dbrock changed the title urbit: 2016-06-02 -> 2016-11-01 urbit: 2016-06-02 -> 0.4 Dec 5, 2016
@vcunat
Copy link
Member

vcunat commented Dec 13, 2016

/cc maintainer @laMudri.

@vcunat vcunat merged commit 8c0f475 into NixOS:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants