Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreutils: 8.25 -> 8.26 #21234

Merged
merged 1 commit into from
Dec 17, 2016
Merged

coreutils: 8.25 -> 8.26 #21234

merged 1 commit into from
Dec 17, 2016

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented Dec 17, 2016 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@l2dy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @viric and @vcunat to be potential reviewers.

@NeQuissimus NeQuissimus merged commit ee28ea0 into NixOS:master Dec 17, 2016
@l2dy l2dy deleted the coreutils-up branch December 17, 2016 15:26
@vcunat
Copy link
Member

vcunat commented Dec 17, 2016

To master directly?!

@shlevy
Copy link
Member

shlevy commented Dec 17, 2016

@NeQuissimus Please don't merge stdenv-changing commits directly to master, that's what staging is for.

@vcunat
Copy link
Member

vcunat commented Dec 17, 2016

So revert there and re-merge to staging?

@NeQuissimus
Copy link
Member

Oh, sorry... My bad, I missed that...

vcunat added a commit that referenced this pull request Dec 17, 2016
@vcunat
Revert "Merge pull request #21234 from l2dy/coreutils-up"
ffb90e8 
This reverts commit ee28ea0, reversing
changes made to f281ce8.
Moving to staging instead.
vcunat added a commit that referenced this pull request Dec 17, 2016
@vcunat
Revert "Revert "Merge pull request #21234 from l2dy/coreutils-up""
3a0f197 
This reverts commit ffb90e8.
This moves the coreutils update from master.
@vcunat
Copy link
Member

vcunat commented Dec 17, 2016

Moved.

@NeQuissimus
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@l2dy @mention-bot @vcunat @shlevy @NeQuissimus