darwin.stdenv: remove openssl #21101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
added
1.severity: mass-darwin-rebuild
6.topic: darwin
|
@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aneeshusa, @vcunat and @chaoflow to be potential reviewers. |
This was referenced Dec 12, 2016
|
Can you elaborate on what your goal is here? Is it to reduce closure size? If so, how much does it improve that situation? |
|
The main thing I would like is to make diff with the linux stdenv smaller, the main things that I would like to get rid of are |
|
Ah okay!
…On Mon, Dec 12, 2016 at 14:52 Daiderd Jordan ***@***.***> wrote:
The main thing I would like is to make diff with the linux stdenv smaller,
the main things that I would like to get rid of are curl and openssl.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#21101 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKP4tZDBBq954xLqStGhy-AoVeR5Ufks5rHaYCgaJpZM4LKpZr>
.
|
|
I think the main thing that brings in a lot of stuff is cmake, I'm not sure why it uses |
|
Probably because it's nice for us to not have a bunch of different versions
of things floating around. If we need to apply a patch or fix to OpenSSL,
people might be surprised that CMake isn't using them because it bundles
its own
…On Mon, Dec 12, 2016 at 14:58 Daiderd Jordan ***@***.***> wrote:
I think the main thing that brings in a lot of stuff is cmake, I'm not
sure why it uses --system-libs.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#21101 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKP-k2NZU__n9BhCoPFyN3BqHanwAAks5rHadSgaJpZM4LKpZr>
.
|
|
It doesn't pull in openssl directly, it's stuff like curl and libarchive. |
LnL7
commented
Dec 14, 2016
| -e 's|-llzo2|-L${lzo}/lib -llzo2|' | ||
| '' + optionalString withOpenssl '' | ||
| sed -i $lib/lib/libarchive.la \ | ||
| -e 's|-lcrypto|-L${openssl.out}/lib -lcrypto| |
|
Closing in favor of #21596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Together with #21078 this will get rid of
opensslandlzoin the darwin stdenv.I'm testing a branch WIP with #21078, #21099 and #21101.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)