Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3715 and the same problem with forall and comment #3727

Merged
merged 1 commit into from Dec 22, 2016

Conversation

firejox
Copy link
Contributor

@firejox firejox commented Dec 18, 2016

Fixes #3715.
And now

def foo(a : T) forall T
  #
end

def bar
  1
  #
rescue
end

will work fine

@asterite
Copy link
Member

Thanks! But could you a spec for those cases? In the diff I only see you changed one spec, which doesn't prove the above code snippets are fixed.

@firejox
Copy link
Contributor Author

firejox commented Dec 19, 2016

@asterite Updated, I have add some spec for that.

@asterite
Copy link
Member

Hmm... This:

def bar
  1
  #
rescue
end

Seems to change to this:

def bar
  1 #
rescue
end

which doesn't seem to be right.

@firejox
Copy link
Contributor Author

firejox commented Dec 20, 2016

@asterite Well, I choose the way with smallest changed for that since I am not sure which one
formatting would be better. The different result is depended on the arguments of
skip_space_or_newline on

write_line unless skip_space_or_newline

And now update with another result, hope it is good formatting 😄

@asterite
Copy link
Member

Thank you, it's working great now! 💜

@asterite asterite merged commit e7d09e0 into crystal-lang:master Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants