Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zdoom: Fix typo from 1cc9d9ef2ce80dee5c8f2ef9f8ae20ae76337d73 #21254

Merged
merged 1 commit into from
Dec 18, 2016

Conversation

Ericson2314
Copy link
Member

No description provided.

@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @Lassulus and @chaoflow to be potential reviewers.

@Ericson2314 Ericson2314 merged commit 508d949 into NixOS:master Dec 18, 2016
@Ericson2314 Ericson2314 deleted the ctrl-t branch December 18, 2016 09:29
@abbradar
Copy link
Member

Ouch, thank you very much. It's strange that none of my tests caught this...

@Ericson2314
Copy link
Member Author

Don't feel bad, I broke nixpkgs recently too! We really need better CI so these things aren't possible; it's stupid to put the onus on us humans.

I'm going to make a label or something collecting evidence.

@abbradar
Copy link
Member

abbradar commented Dec 18, 2016

I think a good way might be to split tests. One tries to build everything (and is judged with a grain of salt like current Travis tests) and the other just does full evaluation of packages themselves and meta. I thought that we already do that since Travis has two tests, but I have often seen the first one (which I supposed to be evaluation) downloading and building things -- that's why I more or less stopped being attentive to it with time, too (and relied on me running them by hand).

Fixing this would be a good first step but I'm sure that has been thought of before. Whom can we ask about current Travis state?

@Ericson2314
Copy link
Member Author

Ericson2314 commented Mar 15, 2017

https://github.com/hercules-ci/hercules I hope will save the day, with sufficient build compute capacity. I see no solution build making sure everything in each (merge) commit builds before bumping the master ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants