Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving taxonomy plugin deactivation #2583

Merged
merged 4 commits into from Dec 5, 2016
Merged

Improving taxonomy plugin deactivation #2583

merged 4 commits into from Dec 5, 2016

Conversation

felixfontein
Copy link
Contributor

Fixes #2581.

@felixfontein felixfontein mentioned this pull request Dec 5, 2016
Closed
Kwpolska
Kwpolska approved these changes Dec 5, 2016
View reviewed changes
nikola/nikola.py
@@ -351,6 +351,14 @@
}
}

# Mapping old pre-taxonomy plugin names to new post-taxonomy plugin names
PLUGIN_NAME_MAP = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAXONOMY_PLUGIN_NAME_MAP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about TAXONOMY_COMPATIBILITY_PLUGIN_NAME_MAP? That also emphasizes that this is about compatibility.

@felixfontein felixfontein merged commit 122380a into master Dec 5, 2016
@felixfontein felixfontein deleted the improving-taxonomy-plugin-deactivation branch December 5, 2016 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska