Making INDEX_PATH, RSS_PATH and AUTHOR_PATH translatable #2584
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Dec 6, 2016
| @@ -73,15 +73,15 @@ def get_classification_friendly_name(self, author, lang, only_last_component=Fal | |||
|
|
|||
| def get_overview_path(self, lang, dest_type='page'): | |||
| """A path handler for the list of all classifications.""" | |||
| return [self.site.config['AUTHOR_PATH']], 'always' | |||
| return [self.site.config['AUTHOR_PATH'][lang]], 'always' | |||
There was a problem hiding this comment.
Always call TranslatableSettings with (lang), never index them.
Kwpolska
reviewed
Dec 6, 2016
| @@ -389,6 +389,7 @@ HIDDEN_CATEGORIES = [] | |||
| # output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of tags) | |||
There was a problem hiding this comment.
I know this was there before, but while you’re at it, please change this to:
# Path to author pages. Final locations are:
# output / TRANSLATION[lang] / AUTHOR_PATH / index.html (list of authors)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.html (list of posts by an author)
# output / TRANSLATION[lang] / AUTHOR_PATH / author.xml (RSS feed for an author)
# (translatable)
Kwpolska
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last three checkmarks for #1914.
(fixes #1914)