Ensure wrapper usage #3611
Merged
Ensure wrapper usage #3611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
commented
Nov 30, 2016
| @@ -1,3 +1,5 @@ | |||
| {% raise("Please use `make spec` or `bin/crystal` when running specs, or set the i_know_what_im_doing flag if you know what you're doing") unless env("CRYSTAL_HAS_WRAPPER") || flag?("i_know_what_im_doing") %} | |||
There was a problem hiding this comment.
It may be better to redirect users to the contributing guide instead of the answer directly.
|
Great! Thanks @RX14! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes compiling the compiler or specs fail when you attempt to compile without
bin/crystal. Note that attempting to require parts of the compiler will never fail, so programs which reuse parts of the compiler are unaffected.I also added a bit to
CONTRIBUTING.mdto mentionmake helpand a few other fixes.