Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mirage/mirage
base: e10a18b392e7
Choose a base ref
...
head repository: mirage/mirage
compare: 60a3f8b7d480
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 13, 2016

  1. FS: remove format and Format_unknown 

    `format` is similar to `connect` which we removed previously from the
common interface: it is likely to be implementation-specific (e.g.
number of inodes, number of superblocks etc etc)

Furthermore it seems strange to have to acquire a `FS.t` handle in order
to be able to format a filesystem. This requires that implementations
track whether the `FS.t` is formatted or not (e.g. with a Some or None)
and then all operations may return `Format_unknown` (which they currently
don't). Removing `format` and `Format_error` fixes this problem.

With this change, `Fs.error` is a proper subset of `Fs.write_error`.

Signed-off-by: David Scott <dave@recoil.org>
    @djs55
    djs55 committed Dec 13, 2016
    Copy the full SHA
    b0e8d28 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #733 from djs55/fs-format 

    FS: remove `format` and `Format_unknown`
    @djs55
    djs55 committed Dec 13, 2016
    Copy the full SHA
    60a3f8b View commit details
    Browse the repository at this point in the history