shell_cmds: init at 198 #21133
Merged
shell_cmds: init at 198 #21133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin, @pikajude and @LnL7 to be potential reviewers. |
pSub
added
8.has: package (new)
6.topic: darwin
LnL7
suggested changes
Dec 14, 2016
| @@ -40,6 +40,7 @@ let | |||
| basic_cmds = "55"; | |||
| adv_cmds = "163"; | |||
| file_cmds = "264.1.1"; | |||
| shell_cmds = "198"; | |||
There was a problem hiding this comment.
The version of 10.11.6 is shell_cmds-187, I think this one is from 10.12.1.
There was a problem hiding this comment.
good catch. should be fixed
| --replace "FCBA169514A146D000AA698B /* PBXTargetDependency */," "" \ | ||
| --replace "FCBA168B14A146D000AA698B /* PBXTargetDependency */," "" \ | ||
| --replace "FCBA165914A146D000AA698B /* PBXTargetDependency */," "" \ | ||
| --replace "FCBA168714A146D000AA698B /* PBXTargetDependency */," "" |
There was a problem hiding this comment.
Does this generally work between versions?
matthewbauer
force-pushed
the
shell_cmds
branch
from
2c91f16
to
83c7660
Compare
LnL7
approved these changes
Dec 15, 2016
|
Wonderful, thanks! |
|
Also noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds Apple's shell_cmds which contains the following binaries:
These are disabled currently because they don't build:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)fixes #11707