Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes #21130

Merged
merged 4 commits into from Dec 14, 2016
Merged

small fixes #21130

merged 4 commits into from Dec 14, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@tohl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @viric and @7c6f434c to be potential reviewers.

@Mic92 Mic92 merged commit c3edaab into NixOS:master Dec 14, 2016
@Mic92
Copy link
Member

Mic92 commented Dec 14, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mention-bot @Mic92