Keyword arguments in path handlers #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
The taxonomy plugin's path handler for indexes can already handle page numbers when they are returned from a taxonomy's |
|
Do you still want to do the future PR, or should I throw something together? |
|
I'll do it this weekend, I think I know where to look. And I should figure
out how this code works anyways.
…--
Chris Warrick <https://chriswarrick.com/>
On 8 Dec 2016 07:53, "Felix Fontein" <notifications@github.com> wrote:
Do you still want to do the future PR, or should I throw something together?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2585 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAT-m2hGB7xiGdv-rDN8VhvoG6Gf17TRks5rF6lXgaJpZM4LFxzU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the generic functionality needed for #2580. I’ll try to do it for the Taxonomy stuff in a future PR (first, I need to understand the thing)
cc @felixfontein