Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

physlock: git-20150126 -> 0.5 #20951

Closed
wants to merge 1 commit into from
Closed

physlock: git-20150126 -> 0.5 #20951

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 6, 2016 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij to be a potential reviewer.

joachifm
joachifm reviewed Dec 8, 2016
View reviewed changes
pkgs/misc/screensavers/physlock/default.nix
src = fetchFromGitHub {
owner = "muennich";
repo = "physlock";
rev = "b64dccc8c22710f8bf01eb5419590cdb0e65cabb";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could simply set rev = v${version} & retain the use of fetchFromGitHub (it basically expands to your new code).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that without fetchFromGitHub the hash of the tarball is unstable over time.

@grahamc
Copy link
Member

grahamc commented Dec 31, 2016 •
edited

Merged in 59dbcef thank you!

@grahamc grahamc closed this Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@magnetophon @mention-bot @grahamc @joachifm @7c6f434c @pSub