-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] FASTA is slow #3529
Comments
That version is strange though, it calls |
You should confirm this on a newer JRuby and Graal than I am using, but:
This is using the version of the benchmark linked above (without eval). The MRI and JRuby without truffle is faster than JRuby with truffle. I have a similar benchmark which is essentially the same, but replaces the function with |
I've been playing with this a bit today. I saw similar numbers for MRI 2.3 and JRuby, while JRuby+Truffle was roughly twice (~10s) what @vext01 reported. There's been a lot of changes in our implementation since these numbers were originally reported. In particular, we've completed changed over to a rope-based String representation. There have been changes in Graal, too. So I'm willing to attribute the difference there to the project evolving over the past 7 months. I've pushed through a couple small changes to optimize some calls. That has brought us to ~7-8s. Beyond that, I've been trying to break the problem down. The repeat_fasta method doesn't run long enough to compile at all. And that accounts for ~4.5s of the 7-8s I'm seeing. I'll keep investigating and see what I can do for the other two fasta methods. |
https://github.com/softdevteam/warmup_experiment/blob/ruby_slow/benchmarks/fasta/ruby/bench.rb
The text was updated successfully, but these errors were encountered: