Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-serve user added to nix-daemon allowed users #11784

Closed
wants to merge 1 commit into from
Closed

nix-serve user added to nix-daemon allowed users #11784

wants to merge 1 commit into from

Conversation

msteen
Copy link
Contributor

@msteen msteen commented Dec 17, 2015

Without the nix-serve user in the allowed users of the Nix daemon,
it will not have access to the Nix store, which will result in internal server errors.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @dezgeg, @wkennington and @robbinch to be potential reviewers

@@ -66,5 +66,7 @@ in
description = "Nix-serve user";
uid = config.ids.uids.nix-serve;
};

nix.allowedUsers = [ "nix-serve" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that setting this overrides the default value (["*"]) so it will actually lock out other users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do what I intent it to do, add an element to nix.allowedUsers if the user overwrote the default value?

Without the nix-serve user in the allowed users of the Nix daemon,
it will not have access to the Nix store, which will result in internal server errors.
@msteen
Copy link
Contributor Author

msteen commented Dec 17, 2015

@edolstra I added an additional value constructor called mkIfUserDefined, which will only assign the value if the user defined it. This allows you to have generous defaults such as those being used in nix.allowedUsers, while still making it possible for modules to extend the user supplied definitions where this makes sense.

@zimbatm
Copy link
Member

zimbatm commented Feb 26, 2016

Hi, is this still the case ? I haven't had any issues with the nix-daemon lately and don't know how to reproduce the issue.

@thufschmitt
Copy link
Member

(triage) can this be closed ?

@joachifm
Copy link
Contributor

Closing as abandoned.

@joachifm joachifm closed this Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants