Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String#new throws an unknown kwarg exception if passed an unknown option #3546

Closed
wants to merge 1 commit into from

Conversation

cheald
Copy link
Contributor

@cheald cheald commented Dec 17, 2015

MRI uses kwargs to accept the encoding parameter for String#new. This patch causes JRuby to emulate that behavior, so it'll noisily complain if you pass an unknown parameter, rather than just silently swallowing it. Tests included.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@headius headius closed this Mar 1, 2016
@enebo enebo modified the milestone: Non-Release May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants